Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): user service conflict with fido2 and script enhancement #3767

Merged
merged 18 commits into from
Feb 2, 2023
Merged

fix(config-api): user service conflict with fido2 and script enhancement #3767

merged 18 commits into from
Feb 2, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Feb 2, 2023

Prepare

Description

Target issue

closes #3766 #3682

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
feat(config-api): default template script exclusion and locationType
a9dd286
@pujavs
feat(config-api): script enhancement
3d5ae6c
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
3cbf47b 
…ns-config-api-feat
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
51d390d 
…ns-config-api-feat
@pujavs
feat(config-api): updated swagger spec
06c9a01
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
de5d9e2 
…ns-config-api-feat
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
1f55079 
…ns-config-api-feat
@pujavs
feat(config-api): reverted user config changes
e75dd13
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
5bba6e0 
…ns-config-api-feat
@pujavs
feat(config-api): swagger changes
56861d7
@pujavs
feat(config-api): user service changes
09be774
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
5d349a3 
…ns-config-api-feat
@pujavs
feat(config-api): userservice conflict with fido2
2341231
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@moabu moabu merged commit 5753d39 into main Feb 2, 2023
@moabu moabu deleted the jans-config-api-feat branch February 2, 2023 19:51
This was referenced Feb 22, 2023
Merged
Merged
This was referenced Feb 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-api): startup issue due to fido2 user service conflict
3 participants
@pujavs @moabu @mo-auto