Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-cli-tui): depracation of call to setup.py when wheel is absent #3804

Closed
SafinWasi opened this issue Feb 7, 2023 · 0 comments · Fixed by #3835
Closed

fix(jans-cli-tui): depracation of call to setup.py when wheel is absent #3804

SafinWasi opened this issue Feb 7, 2023 · 0 comments · Fixed by #3835
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request

Comments

@SafinWasi
Copy link
Contributor

SafinWasi commented Feb 7, 2023 •
edited
Loading

Description

During compilation, make zipapp displays the following warning:

DEPRECATION: jans-cli-tui is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

This is due to a future deprecation of calling setup.py install when the wheel package is absent. As discussed in pypa/pip#8559, pip will attempt to build a wheel first before doing the legacy install. This can be solved by installing the wheel package to the user's virtual environment or by switching to a pyproject.toml project format.
@SafinWasi SafinWasi changed the title feat(jans-cli-tui): depracation of call to setup.py when wheel is absent fix(jans-cli-tui): depracation of call to setup.py when wheel is absent Feb 7, 2023
@mo-auto mo-auto added comp-jans-cli-tui Component affected by issue or PR kind-feature Issue or PR is a new feature request kind-bug Issue or PR is a bug in existing functionality labels Feb 7, 2023
devrimyatar added a commit that referenced this issue Feb 13, 2023
@devrimyatar
fix: jans-cli-tui include pyproject.toml (ref: #3804)
022f3ff
@devrimyatar devrimyatar mentioned this issue Feb 13, 2023
Merged
yuriyz pushed a commit that referenced this issue Feb 13, 2023
@devrimyatar
fix: jans-cli-tui include pyproject.toml (ref: #3804) (#3835)
f250372
pujavs pushed a commit that referenced this issue Feb 14, 2023
@devrimyatar @pujavs
fix: jans-cli-tui include pyproject.toml (ref: #3804) (#3835)
894f5f0
This was referenced Feb 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jans-cli-tui include pyproject.toml JanssenProject/jans
2 participants
@SafinWasi @mo-auto