Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-pycloudlib): avoid overwritten data by using merge strategy for AWS wrappers #3832

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Feb 10, 2023

Prepare


Description

Target issue

closes #3830

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner February 10, 2023 18:08
@mo-auto mo-auto added comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality labels Feb 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #3832 (df37efd) into main (809b9db) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3832      +/-   ##
==========================================
- Coverage   68.30%   68.13%   -0.18%     
==========================================
  Files          30       30              
  Lines        2379     2385       +6     
==========================================
  Hits         1625     1625              
- Misses        754      760       +6     
Flag Coverage Δ
unittests 68.13% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns-pycloudlib/jans/pycloudlib/config/aws_config.py 35.00% <0.00%> (-1.37%) ⬇️
...ns-pycloudlib/jans/pycloudlib/secret/aws_secret.py 35.80% <0.00%> (-1.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@moabu moabu merged commit cf0d4e3 into main Feb 10, 2023
@moabu moabu deleted the cn-aws-secrets branch February 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-pycloudlib): re-running set_all method overwrites existing secrets/configs in AWS Secrets
3 participants