Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-fido2): Exception handling for endpoints #3902

Closed
maduvena opened this issue Feb 21, 2023 · 2 comments · Fixed by #4139 or #5689
Closed

fix(jans-fido2): Exception handling for endpoints #3902

maduvena opened this issue Feb 21, 2023 · 2 comments · Fixed by #4139 or #5689
Assignees
@Milton-Ch
Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.17

Comments

@maduvena
Copy link
Contributor

Steps to reproduce:

  1. visit - https://my.jans.server/jans-fido2/restv1/assertion/authentication
  2. Exception
    image
  3. Exception handling should be on the same lines of https://my.jans.server/jans-auth/restv1/authorize and here is a reference - https://github.com/JanssenProject/jans/blob/main/jans-auth-server/server/src/main/java/io/jans/as/server/authorize/ws/rs/AuthorizeRestWebServiceImpl.java
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 21, 2023
@moabu moabu added this to the 1.0.9 milestone Mar 1, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 9, 2023
@jmunozherbas jmunozherbas mentioned this issue Mar 14, 2023
Merged
5 tasks
@yurem yurem mentioned this issue Mar 14, 2023
Closed
@yurem
Copy link
Contributor

yurem commented May 30, 2023

When I try to execute curl -X POST <server>/jans-fido2/restv1/attestation/registration I get stack trace in client response

@yurem yurem reopened this May 30, 2023
@yurem yurem modified the milestones: 1.0.10, 1.0.14 May 30, 2023
@moabu moabu modified the milestones: 1.0.14, 1.0.15 Jun 20, 2023
@yurem
Copy link
Contributor

yurem commented Jun 20, 2023

For reference you can take a look on jans auth how it handle such excpetions

@moabu moabu modified the milestones: 1.0.15, 1.0.16 Jul 12, 2023
@moabu moabu assigned Milton-Ch and unassigned jmunozherbas and moabu Jul 18, 2023
@Milton-Ch Milton-Ch mentioned this issue Jul 29, 2023
Merged
2 tasks
@moabu moabu modified the milestones: 1.0.16, 1.0.17 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Milton-Ch Milton-Ch

Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.17
6 participants
@yurem @maduvena @jmunozherbas @moabu @mo-auto @Milton-Ch