Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Illegal op_policy_uri parameter: - exclude entries with blank values from discovery response (oxauth counterpart) #4888

Closed
yuriyz opened this issue May 9, 2023 · 0 comments · Fixed by #4934
Assignees
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality kind-enhancement Issue or PR is an enhancement to an existing functionality
Milestone

Comments

@yuriyz
Copy link
Contributor

yuriyz commented May 9, 2023

Describe the issue

op_policy_uri being blank is causing a ParseException on large open source tools like spring oauth, and pac4j leveraging nimbusds. This value either needs to be removed all together or have a value in it.

oxauth counterpart GluuFederation/oxAuth#1823

Steps To Reproduce

Steps to reproduce the behavior:

  1. Get an example project for spring oidc
  2. attempt to login
  3. receive error stating illegal op_policy_uri parameter

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu 20
  • Gluu version - 4.5.0.Final

Additional context

Here is the code that is being used within nimbusds that is throwing the error
if (jsonObject.get("op_policy_uri") != null) { try { as.setPolicyURI(JSONObjectUtils.getURI(jsonObject, "op_policy_uri")); } catch (IllegalArgumentException e) { throw new ParseException("Illegal op_policy_uri parameter: " + e.getMessage()); } }

@yuriyz yuriyz self-assigned this May 9, 2023
@yuriyz yuriyz added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-auth-server Component affected by issue or PR labels May 9, 2023
@yuriyz yuriyz added this to the 1.0.13 milestone May 9, 2023
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label May 9, 2023
yuriyz added a commit that referenced this issue May 10, 2023
…ries with blank values from discovery response (oxauth counterpart) #4888
@moabu moabu modified the milestones: 1.0.13, 1.0.14 May 10, 2023
yuriyz added a commit that referenced this issue May 10, 2023
…ries with blank values from discovery response (oxauth counterpart) #4888 (#4934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
3 participants