Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): rely on end_session feature flag value when return discovery response #5255

Closed
6 tasks
yuriyz opened this issue Jun 14, 2023 · 1 comment · Fixed by #7766
Closed
6 tasks

feat(jans-auth-server): rely on end_session feature flag value when return discovery response #5255

yuriyz opened this issue Jun 14, 2023 · 1 comment · Fixed by #7766
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Milestone
1.1.0

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jun 14, 2023

Description

Somehow we don't have configuration property for frontchannel_logout_supported but we do have it for frontchannel_logout_session_supported. However we don't need it and we should remove frontchannel_logout_session_supported as well. Instead we should rely on end_session feature flag. When it is enabled both frontchannel_logout_supported and frontchannel_logout_session_supported must return true. If it is disabled both should return false. I'm opening improvement ticket for it.

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@yuriyz yuriyz self-assigned this Jun 14, 2023
@yuriyz yuriyz added kind-feature Issue or PR is a new feature request comp-jans-auth-server Component affected by issue or PR labels Jun 14, 2023
@yuriyz yuriyz added this to the 1.0.15 milestone Jun 14, 2023
@yuriyz
Copy link
Contributor Author

yuriyz commented Jun 15, 2023

Back channel discovery values must be updated as well:
backchannel_logout_supported and backchannel_logout_session_supported.

@moabu moabu modified the milestones: 1.0.15, 1.0.16 Jul 12, 2023
@moabu moabu modified the milestones: 1.0.16, 1.0.17 Aug 2, 2023
@moabu moabu modified the milestones: 1.0.17, 1.0.18 Sep 18, 2023
@moabu moabu modified the milestones: 1.0.18, 1.0.21 Nov 22, 2023
@moabu moabu modified the milestones: 1.0.21, 1.0.22 Dec 14, 2023
@moabu moabu modified the milestones: 1.0.22, 1.0.23 Feb 1, 2024
yuriyz added a commit that referenced this issue Feb 19, 2024
@yuriyz
feat(jans-auth-server): rely on end_session feature flag value when r…
d40af75 
…eturn discovery response #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz mentioned this issue Feb 19, 2024
Merged
2 tasks
yuriyz added a commit that referenced this issue Feb 19, 2024
@yuriyz
fix: corrected assertion in RegistrationRestWebServiceHttpTest #5255
79022f1 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yurem pushed a commit that referenced this issue Feb 19, 2024
@yuriyz
feat(jans-auth-server): rely on end_session feature flag value when r…
78cc0d7 
…eturn discovery response #5255 (#7766)

* feat(jans-auth-server): rely on end_session feature flag value when return discovery response #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* fix: corrected assertion in RegistrationRestWebServiceHttpTest #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yurem pushed a commit that referenced this issue Feb 20, 2024
@yuriyz @yurem
feat(jans-auth-server): rely on end_session feature flag value when r…
8488e5d 
…eturn discovery response #5255 (#7766)

* feat(jans-auth-server): rely on end_session feature flag value when return discovery response #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* fix: corrected assertion in RegistrationRestWebServiceHttpTest #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
devrimyatar pushed a commit that referenced this issue Feb 27, 2024
@yuriyz @devrimyatar
feat(jans-auth-server): rely on end_session feature flag value when r…
dc2a9cf 
…eturn discovery response #5255 (#7766)

* feat(jans-auth-server): rely on end_session feature flag value when return discovery response #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* fix: corrected assertion in RegistrationRestWebServiceHttpTest #5255

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.1.0
2 participants
@yuriyz @moabu