Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-auth-server): improve session lifetime properties #5275

Closed
6 tasks
yuriyz opened this issue Jun 16, 2023 · 0 comments · Fixed by #7653
Closed
6 tasks

feat(jans-auth-server): improve session lifetime properties #5275

yuriyz opened this issue Jun 16, 2023 · 0 comments · Fixed by #7653
Assignees
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Milestone

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jun 16, 2023

Description

Mike: The properties for sessionLifetime are a little confusing.
I wish we had one property for "cookie lifetime"
and one for "session lifetime" (i.e. the database entity)
the current names and corresponding defintions of the properties are very confusing.

YuriyZ: Idea was that we have sessionIdLifetime which sets session lifetime in both cookie and server object, so it's same (in sync) and with serverSessionIdLifetime we overwrite server object lifetime when needed. But yeah, confusion comes because we don't have dedicated property for each case, e.g.

  • cookie case - sessionIdCookieLifetime
  • server object case - sessionIdLifetime
    I can rename and change behavior accordingly

Mike: I think it would help a lot
We can just set the defaults the same...
sessionIdLifetime should = sessionIdCookieLifetime

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@yuriyz yuriyz added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jun 16, 2023
@yuriyz yuriyz added this to the 1.0.15 milestone Jun 16, 2023
@yuriyz yuriyz self-assigned this Jun 16, 2023
@moabu moabu modified the milestones: 1.0.15, 1.0.16 Jul 12, 2023
@moabu moabu modified the milestones: 1.0.16, 1.0.17 Aug 2, 2023
@moabu moabu modified the milestones: 1.0.17, 1.0.18 Sep 18, 2023
@moabu moabu modified the milestones: 1.0.18, 1.0.21 Nov 22, 2023
@moabu moabu modified the milestones: 1.0.21, 1.0.22 Dec 14, 2023
@moabu moabu modified the milestones: 1.0.22, 1.0.23 Feb 1, 2024
yuriyz added a commit that referenced this issue Feb 6, 2024
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Feb 6, 2024
…7653)

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants