feat(jans-auth-server): improve session lifetime properties #5275
Labels
comp-jans-auth-server
Component affected by issue or PR
kind-feature
Issue or PR is a new feature request
Milestone
Description
Mike: The properties for sessionLifetime are a little confusing.
I wish we had one property for "cookie lifetime"
and one for "session lifetime" (i.e. the database entity)
the current names and corresponding defintions of the properties are very confusing.
YuriyZ: Idea was that we have sessionIdLifetime which sets session lifetime in both cookie and server object, so it's same (in sync) and with
serverSessionIdLifetime
we overwrite server object lifetime when needed. But yeah, confusion comes because we don't have dedicated property for each case, e.g.sessionIdCookieLifetime
sessionIdLifetime
I can rename and change behavior accordingly
Mike: I think it would help a lot
We can just set the defaults the same...
sessionIdLifetime should = sessionIdCookieLifetime
Test cases and code coverage
Document the changes
The text was updated successfully, but these errors were encountered: