Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect timestamp on files copied from one to another pod #613

Closed
iromli opened this issue Jan 17, 2022 · 0 comments · Fixed by #627
Closed

Incorrect timestamp on files copied from one to another pod #613

iromli opened this issue Jan 17, 2022 · 0 comments · Fixed by #627
Assignees
@iromli @moabu
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.0

Comments

@iromli
Copy link
Contributor

iromli commented Jan 17, 2022 •
edited
Loading

Describe the bug

File copied from pod to another pod using KubernetesMeta.copy_to_container method has incorrect timestamp set to Jan 1, 1970.

To Reproduce
Steps to reproduce the behavior:

  1. Run janssenproject/certmanager container to rotate auth-server keys (auth-keys.jks and auth-keys.json) using the following command certmanager patch auth
  2. Wait until the process completed
  3. Check timestamp on /etc/certs/auth-keys.jks and /etc/certs/auth-keys.json files inside auth-server pods; the timestamp are set to Jan 1, 1970

Expected behavior
File copied from pod to another pod using KubernetesMeta.copy_to_container method should have correct timestamp.

Additional context
The tar command is missing option -m to prevent timestamp restored to Jan 1, 1970.
@iromli iromli added kind-bug Issue or PR is a bug in existing functionality comp-docker-jans-certmanager comp-jans-pycloudlib labels Jan 17, 2022
@iromli iromli added this to the 1.0.0 milestone Jan 17, 2022
@iromli iromli changed the title Incorrect timestamp on files copied from certmanager to auth-server pods Incorrect timestamp on files created by copy_to_container process Jan 17, 2022
@iromli iromli changed the title Incorrect timestamp on files created by copy_to_container process Incorrect timestamp on files copied from one to another pod Jan 17, 2022
iromli added a commit that referenced this issue Jan 17, 2022
@iromli
fix(pycloudlib): missing tar option to not restore file timestamp #613
32825aa
iromli added a commit that referenced this issue Jan 19, 2022
@iromli
fix(pycloudlib): missing tar option to not restore file timestamp #613
1846fc9
@iromli iromli mentioned this issue Jan 19, 2022
Merged
@iromli iromli linked a pull request Jan 19, 2022 that will close this issue
fix(pycloudlib): missing tar option to not restore file timestamp #613 #627
Merged
moabu pushed a commit that referenced this issue Jan 20, 2022
@iromli @mo-auto
fix(pycloudlib): missing tar option to not restore file timestamp #613 (
d19fbfd 
#627)

* fix(pycloudlib): missing tar option to not restore file timestamp #613

* chore(jans-pycloudlib): updated build (#628)

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>

* chore(jans-pycloudlib): updated build (#652)

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>

Co-authored-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
This was referenced Jan 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 14, 2022
Closed
Closed
This was referenced Mar 1, 2022
Merged
Merged
Merged
Merged
This was referenced Mar 1, 2022
Merged
Merged
Merged
Merged
This was referenced Mar 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromli iromli

@moabu moabu

Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

fix(pycloudlib): missing tar option to not restore file timestamp #613 JanssenProject/jans
2 participants
@iromli @moabu