Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private keys for auth-server are not reloaded when using push delay #614

Closed
iromli opened this issue Jan 17, 2022 · 0 comments · Fixed by #626
Closed

Private keys for auth-server are not reloaded when using push delay #614

iromli opened this issue Jan 17, 2022 · 0 comments · Fixed by #626
Assignees
@iromli @moabu
Labels
comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.0

Comments

@iromli
Copy link
Contributor

iromli commented Jan 17, 2022

Describe the bug
The attribute to reload auth-server configuration (jansRevision attribute) isn't updated when privkey-push-delay is set and key-strategy and privkey-push-strategy options having a same value.

To Reproduce
Steps to reproduce the behavior:

  1. Run janssenproject/certmanager container with the following command: certmanager patch auth --opts key-strategy:NEWER --opts privkey-push-delay:60 --opts privkey-push-strategy:NEWER
  2. Wait until the process completed
  3. Check auth-server configuration entry in persistence; jansRevision attribute should be updated twice.

Expected behavior
The attribute to reload auth-server configuration should be updated regardless of key-strategy and privkey-push-strategy options value.
@iromli iromli added kind-bug Issue or PR is a bug in existing functionality comp-docker-jans-certmanager labels Jan 17, 2022
@iromli iromli added this to the 1.0.0 milestone Jan 17, 2022
iromli added a commit that referenced this issue Jan 17, 2022
@iromli
fix(certmanager): ensure jansRevision always updated #614
9541e73
@iromli iromli linked a pull request Jan 17, 2022 that will close this issue
fix(certmanager): bug fixes for patch auth command #616
Closed
iromli added a commit that referenced this issue Jan 19, 2022
@iromli
fix(certmanager): ensure jansRevision always updated #614
b6ecf89
@iromli iromli linked a pull request Jan 19, 2022 that will close this issue
fix(certmanager): patches for auth handler #626
Merged
@iromli iromli removed a link to a pull request Jan 19, 2022
fix(certmanager): bug fixes for patch auth command #616
Closed
moabu pushed a commit that referenced this issue Jan 20, 2022
@iromli
fix(certmanager): patches for auth handler (#626)
d95453f 
* fix(certmanager): ensure jansRevision always updated #614

* fix(certmanager): ensure backup for auth-server private keys is created #615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromli iromli

@moabu moabu

Labels
comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

fix(certmanager): patches for auth handler JanssenProject/jans
2 participants
@iromli @moabu