Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-jans): allow custom salt #6536

Closed
iromli opened this issue Nov 9, 2023 · 0 comments · Fixed by #6551
Closed

fix(docker-jans): allow custom salt #6536

iromli opened this issue Nov 9, 2023 · 0 comments · Fixed by #6551
Assignees
Labels
comp-charts-jans comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality
Milestone

Comments

@iromli
Copy link
Contributor

iromli commented Nov 9, 2023

In current helm chart values, if salt is defined with empty string, configurator will raise the following validation error:

{'salt': ['Length must be 24.', 'Only alphanumeric characters are allowed']}

configurator should not validate the salt field if it's empty (in favor of self-generating salt).

@iromli iromli self-assigned this Nov 9, 2023
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Nov 9, 2023
@iromli iromli changed the title fix(docker-jans-configurator): allow empty custom salt fix(docker-jans-configurator): allow custom salt Nov 10, 2023
@iromli iromli changed the title fix(docker-jans-configurator): allow custom salt fix(docker-jans): allow custom salt Nov 10, 2023
@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-charts-jans comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants