Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans): allow custom salt #6551

Merged
merged 1 commit into from Nov 13, 2023
Merged

fix(docker-jans): allow custom salt #6551

merged 1 commit into from Nov 13, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 10, 2023

Prepare

Description

Target issue

closes #6536

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner November 10, 2023 19:25
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality labels Nov 10, 2023
@moabu moabu merged commit b099469 into main Nov 13, 2023
2 of 3 checks passed
@moabu moabu deleted the cn-custom-salt branch November 13, 2023 10:18
This was referenced Dec 11, 2023
Merged
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@iromli @devrimyatar
fix(docker-jans): allow custom salt (#6551)
4436d90 
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans): allow custom salt
3 participants
@iromli @moabu @mo-auto