Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes #6566

Merged
merged 5 commits into from
Nov 15, 2023
Merged

docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes #6566

merged 5 commits into from
Nov 15, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Nov 15, 2023 •
edited
Loading

Prepare

Description

Target issue

closes #6382 and removed explicit version pf org.json from config-api pom in-order to reuse the version from jans-bom

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
fix(config-api): source LDAP server test
76099bc
@pujavs
feat(config-api): pom changes for org json
543f1be 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
feat(config-api): sync with main
5cc663d 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
fix(config-api): sync with main
b1d636e 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
docs(config-api): issue 6382 - regen spec to reflect new fields in Cl…
9c141dd 
…ientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

[Jans-Keycloak-Link] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz
Copy link
Contributor

yuriyz commented Nov 15, 2023

I'm merging to unblock Mustafa but some generated resources overwrites @ossdhaval changes. So it has to be made in generation sources and not in spec directly.

image

@yuriyz yuriyz merged commit 592f186 into main Nov 15, 2023
4 of 5 checks passed
@yuriyz yuriyz deleted the jans-config-api_issue branch November 15, 2023 13:23
@pujavs pujavs mentioned this pull request Nov 16, 2023
Closed
@pujavs
Copy link
Contributor Author

pujavs commented Nov 16, 2023

I'm merging to unblock Mustafa but some generated resources overwrites @ossdhaval changes. So it has to be made in generation sources and not in spec directly.

image

@yuriyz, these changes are picked up from source code that @ossdhaval had modified and not directly in spec

@mo-auto mo-auto mentioned this pull request Dec 11, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@pujavs @devrimyatar
docs(config-api): issue 6382 - regen spec to reflect new fields in Cl…
83495f4 
…ientAttributes (#6566)

* fix(config-api): source LDAP server test

* feat(config-api): pom changes for org json

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (TUI): JWT Response for OAuth Token Introspection
2 participants
@pujavs @yuriyz