Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-pycloudlib): set sql_mode while connecting to mysql #7700

Closed
iromli opened this issue Feb 12, 2024 · 0 comments · Fixed by #7713
Closed

fix(jans-pycloudlib): set sql_mode while connecting to mysql #7700

iromli opened this issue Feb 12, 2024 · 0 comments · Fixed by #7713
Assignees
@iromli
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality

Comments

@iromli
Copy link
Contributor

iromli commented Feb 12, 2024

Currently, the SQL persistence layer didn't check for sql_mode in its session, hence when MySQL server is set to non-strict mode, some data will be inserted and truncated without error. This breaks many functionalities, e.g. key rotation. The sql_mode should be set as strict when using SQLAlchemy session.
@iromli iromli self-assigned this Feb 12, 2024
@mo-auto mo-auto added comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality labels Feb 12, 2024
@iromli iromli mentioned this issue Feb 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromli iromli

Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(jans-pycloudlib): set sql_mode while connecting to mysql JanssenProject/jans
2 participants
@iromli @mo-auto