Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-pycloudlib): set sql_mode while connecting to mysql #7713

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Feb 13, 2024

Prepare


Description

Target issue

closes #7700

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner February 13, 2024 17:10
@mo-auto mo-auto added comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality labels Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@02cdba4). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7713   +/-   ##
=======================================
  Coverage        ?   60.65%           
=======================================
  Files           ?       36           
  Lines           ?     3101           
  Branches        ?        0           
=======================================
  Hits            ?     1881           
  Misses          ?     1220           
  Partials        ?        0           
Flag Coverage Δ
unittests 60.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moabu moabu merged commit 0df5213 into main Feb 14, 2024
2 checks passed
@moabu moabu deleted the cn-pycloudlib-sql-mode branch February 14, 2024 08:59
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'agama parent'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 14, 2024

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed for 'orm'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-pycloudlib): set sql_mode while connecting to mysql
3 participants