Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saml): error in saving TR with samlMetadata #7873

Closed
jv18creator opened this issue Feb 28, 2024 · 4 comments · Fixed by #7894
Closed

fix(saml): error in saving TR with samlMetadata #7873

jv18creator opened this issue Feb 28, 2024 · 4 comments · Fixed by #7894
Assignees
Labels
kind-bug Issue or PR is a bug in existing functionality

Comments

@jv18creator
Copy link
Contributor

Describe the bug
After testing #7523 changes, getting 500 exception on admin-ui-test with below payload.
If I remove the samlMetadata obj from req. body, then I get success.

To Reproduce Use below info
URL: https://admin-ui-test.gluu.org/jans-config-api/kc/saml/trust-relationship/upload
Req Body

{
    "enabled": false,
    "name": "test",
    "displayName": "dtest",
    "description": "desc",
    "spMetaDataSourceType": "uri",
    "spMetaDataFN": "https://mail.google.com/mail/u/0/",
    "releasedAttributes": [],
    "rootUrl": "",
    "adminUrl": "",
    "surrogateAuthRequired": false,
    "spLogoutURL": "",
    "samlMetadata": {
        "nameIDPolicyFormat": "urn:mace",
        "entityId": "http://localhost:4100",
        "singleLogoutServiceUrl": "http://localhost:4100"
    }
}

Expected behavior
Trust-Relation should be created using above mentioned payload.

Screenshots
Screenshot 2024-02-28 at 2 08 26 PM

Additional context
DB type: postgres

@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Feb 28, 2024
@pujavs
Copy link
Contributor

pujavs commented Feb 29, 2024

@jv18creator, fixed this issue via PR#7894
@jv18creator, request you to please verify and revert in-case issue is resolved.

image

@jv18creator
Copy link
Contributor Author

@pujavs
Copy link
Contributor

pujavs commented Mar 1, 2024

@jv18creator change was done yesterday and would be available in todays build.
It seems that you tested with yesterday's nightly build which would not have the code reflected.
I installed todays nightly build and can see the change. Please test with todays build

@jv18creator
Copy link
Contributor Author

thanks @pujavs changes are reflected and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants