Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): Fetching a non-existing trust relationship results in an empty body response and a 200 status #8162

Closed
uprightech opened this issue Mar 28, 2024 · 0 comments
Closed

fix(jans-config-api): Fetching a non-existing trust relationship results in an empty body response and a 200 status #8162

uprightech opened this issue Mar 28, 2024 · 0 comments
Assignees
@uprightech
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@uprightech
Copy link
Contributor

uprightech commented Mar 28, 2024 •
edited
Loading

Describe the bug
Invoking the endpoint /saml/trust-relationship/id/{tr_inum} results in a 200 OK response with an empty body if the specified tr_inum refers to a non-existing trust relationship.

Expected behavior
Invoking said endpoint should result in a 404 not found error with possibly an error object clearly indicating the trust relationship with said inum could not be found.
@uprightech uprightech self-assigned this Mar 28, 2024
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 28, 2024
@uprightech uprightech changed the title fix(jans-config-api): Fetching a non-existing trust relationship results in an exception fix(jans-config-api): Fetching a non-existing trust relationship results in an empty body response and a 200 status Mar 28, 2024
uprightech added a commit that referenced this issue Apr 1, 2024
@uprightech
fi(jans-config-api): return 404 with body when trying to fetch a non-…
3aef560 
…existing trust relationship #8162

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
@uprightech uprightech mentioned this issue Apr 1, 2024
Merged
yuriyz added a commit that referenced this issue Apr 1, 2024
@uprightech @yuriyz
fix(jans-config-api): fetching a non-existing trustrelationship by id…
c71ca5a 
… returns a 200k empty response instead of a 404 Not Found #8162 (#8185)

fi(jans-config-api): return 404 with body when trying to fetch a non-existing trust relationship #8162

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Co-authored-by: YuriyZ <yzabrovarniy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uprightech uprightech

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uprightech @mo-auto