Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): introduce acr mappings and prefixed acr - "agama_<flow name> " #8216

Closed
7 tasks
nynymike opened this issue Apr 3, 2024 · 2 comments · Fixed by #8304
Closed
7 tasks

feat(jans-auth-server): introduce acr mappings and prefixed acr - "agama_<flow name> " #8216

nynymike opened this issue Apr 3, 2024 · 2 comments · Fixed by #8304
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request

Comments

@nynymike
Copy link
Contributor

nynymike commented Apr 3, 2024 •
edited by ossdhaval
Loading

Let's say we have an authn request for acr_values=org.gluu.agama.flow1. For an unknown acr, could we check it against all exsiting agama flows, and if it matches, invoke the agama bridge? Of course there would need to be a feature flag.
And we might want to filter what flows are exposed in the wild... but this would solve a big problem for agama... adding that extra param means any standard openid connect client can't specify the flow.

Relevant documents that might need updates

Note: Developer needs to add to this list based on complete understanding of the feature and its implementation

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Apr 3, 2024
@yuriyz
Copy link
Contributor

yuriyz commented Apr 3, 2024

image

@yuriyz yuriyz self-assigned this Apr 3, 2024
@yuriyz yuriyz mentioned this issue Apr 3, 2024
Open
6 tasks
@yuriyz
Copy link
Contributor

yuriyz commented Apr 4, 2024

We will use prefixed version for agama acr with _ as split symbol to avoid url encoding/decoding.
acr_values=agama_<name>

@yuriyz yuriyz changed the title feat(jans-auth-server): Invoke Agama Flow for undefined acr_values values feat(jans-auth-server): introduce acr mappings and prefixed acr - "agama_<flow name> " Apr 4, 2024
yuriyz added a commit that referenced this issue Apr 15, 2024
@yuriyz
feat(jans-auth-server): introduce acr mappings and prefixed acr - "ag…
0128f0a 
…ama_<flow name> " #8216

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz mentioned this issue Apr 15, 2024
Merged
3 tasks
yuriyz added a commit that referenced this issue Apr 16, 2024
@yuriyz
feat(jans-auth-server): added acr mappings support #8216
bef98e9 
#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Apr 17, 2024
@yuriyz
feat(jans-auth-server): invoke agama script for acr_values=agama_<flo…
17e0d78 
…w name> #8216

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Apr 18, 2024
@yuriyz
feat(jans-auth-server): cover acr changes with tests
80dffaa 
#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Apr 18, 2024
@yuriyz
docs(jans-auth-server): documented acr mappings and prefixed acr - "a…
cfcb123 
…gama_<flow name>"

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Apr 18, 2024
@yuriyz
typo
d5a9794 
#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Apr 18, 2024
@yuriyz
feat(jans-auth-server): introduced acr mappings and prefixed acr - "a…
982792d 
…gama_<flow name> " #8216 (#8304)

* feat(jans-auth-server): introduce acr mappings and prefixed acr - "agama_<flow name> " #8216

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added acr mappings support #8216

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): invoke agama script for acr_values=agama_<flow name> #8216

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): cover acr changes with tests

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* docs(jans-auth-server): documented acr mappings and prefixed acr - "agama_<flow name>"

#8216
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@jgomer2001 jgomer2001 mentioned this issue Apr 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
3 participants
@yuriyz @nynymike @mo-auto