Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): spelling mistake in JansAttribute schema #8665

Closed
ossdhaval opened this issue Jun 6, 2024 · 3 comments
Closed

fix(jans-config-api): spelling mistake in JansAttribute schema #8665

ossdhaval opened this issue Jun 6, 2024 · 3 comments
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@ossdhaval
Copy link
Contributor

When we fetch the JansAttribute schema using the command below:

/opt/jans/jans-cli/config-cli.py --schema JansAttribute > /tmp/attribute.json

It show schema which has a spelling mistake, where requred should be spelt as required
@ossdhaval ossdhaval added the comp-jans-config-api Component affected by issue or PR label Jun 6, 2024
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Jun 6, 2024
@pujavs
Copy link
Contributor

pujavs commented Jun 6, 2024

@yurem can i rectify the spelling mistake in JansAttribute model class?

@yurem
Copy link
Contributor

yurem commented Jun 6, 2024

yes, sure we can remove requred property and set/get methods. We not use them in Jans projects

@pujavs pujavs mentioned this issue Jun 7, 2024
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Jun 7, 2024

Fixed via PR 8673

@pujavs pujavs closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ossdhaval @yurem @pujavs @mo-auto