Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed redundant field from core class, added desc for config-api configuration properties #8673

Merged
merged 46 commits into from
Jun 7, 2024

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jun 7, 2024

Prepare


Description

  1. Issue#8662: Adding metadata description to config-api configuration attributes
  2. Issue#8665: Removed redundant requred field

Target issue

closes #8662 #8665

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…thentication issue#8384

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…d service validation

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Copy link

dryrunsecurity bot commented Jun 7, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Sensitive Files Analyzer 0 findings
Authn/Authz Analyzer 0 findings
AppSec Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request cover a wide range of updates to the Jans Config API project, including improvements to the documentation, error handling, and configuration settings. While the changes do not introduce any immediate security vulnerabilities, there are several areas that should be carefully reviewed to ensure the ongoing security and integrity of the application.

Key security considerations include:

  1. Input Validation and Sanitization: Ensure that user input is properly validated and sanitized, especially for features like asset uploads, user management, and API endpoints that interact with external data.
  2. Access Control and Authorization: Review the access control settings and permissions to ensure that only authorized users or components can perform sensitive operations, such as user management or configuration changes.
  3. Logging and Monitoring: Ensure that appropriate logging and monitoring mechanisms are in place to detect and respond to any security-related issues or anomalies.
  4. Secure Configuration Management: Carefully review the configuration settings, especially those related to security-sensitive functionality, to ensure that they are properly implemented and aligned with the application's security requirements.
  5. Dependency Management: Verify that all external libraries and dependencies used in the application are up-to-date and secure, and that any potential vulnerabilities are addressed.

Overall, the changes in this pull request appear to be focused on improving the functionality and maintainability of the Jans Config API, but it's essential to thoroughly review the implementation and deployment of these changes to ensure the ongoing security and reliability of the application.

Files Changed:

  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/AgamaConfiguration.java: Changes focused on improving the documentation and clarity of the API.
  • docs/admin/config-guide/config-tools/config-api/attribute.md: Removal of the "requred" field from attribute definitions.
  • docs/admin/config-guide/attribute-configuration.md: Documentation updates on managing attributes in the Janssen Server.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/ApiAppConfiguration.java: Changes related to logging configuration, API protection, client configuration, and user attribute management.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/AssetDirMapping.java: Refactoring of the AssetDirMapping class, improving code documentation.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/AuditLogConf.java: Changes to the audit logging configuration, including options to enable/disable logging and control logged header attributes.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/AssetMgtConfiguration.java: Changes related to asset management functionality, including asset uploads, file extension validation, and service module name validation.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/DataFormatConversionConf.java: Changes focused on adding Swagger documentation annotations to the class and its properties.
  • jans-config-api/common/src/main/java/io/jans/configapi/model/configuration/PluginConf.java: Changes focused on adding Swagger annotations to the class properties.
  • jans-config-api/plugins/docs/user-mgt-plugin-swagger.yaml: Changes related to the User Management functionality, including updates to the CustomObjectAttribute, CustomUser, UserAuthenticator, and other related schemas.
  • jans-config-api/plugins/kc-saml-plugin/src/main/java/io/jans/configapi/plugin/saml/rest/IdpResource.java: Changes focused on improving error handling and logging.
  • jans-config-api/server/src/main/resources/example/attribute/attribute-get.json: Removal of the "requred" field from attribute definitions.
  • jans-config-api/server/src/main/java/io/jans/configapi/rest/resource/auth/ConfigBaseResource.java: Changes to the visibility of the getMaxCount() method.
  • jans-config-api/server/src/main/resources/example/attribute/attribute-get-all.json: Removal of the "requred" fiel

Powered by DryRun Security

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jun 7, 2024
@yuriyz yuriyz enabled auto-merge (squash) June 7, 2024 09:17
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 7, 2024

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yuriyz yuriyz merged commit a24c0b9 into main Jun 7, 2024
8 checks passed
@yuriyz yuriyz deleted the jans-config-fix branch June 7, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(config-api): adding swagger description to config-api configuration attributes
4 participants