Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose prometheus metrics via jmx exporter #1573

Merged
merged 7 commits into from
Jun 21, 2022
Merged

feat: expose prometheus metrics via jmx exporter #1573

merged 7 commits into from
Jun 21, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jun 16, 2022 •
edited
Loading

Prepare

Description

Target issue

GH issue: #682

Implementation Details

Prometheus metrics can be exposed via JMX exporter by setting the newly added CN_PROMETHEUS_PORT env, i.e. CN_PROMETHEUS_PORT=9093. The metrics can be scraped by Prometheus or accessed manually by making request to http://$SERVICE:9093/metrics URL.

Test and Document the changes

  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc); see docker-jans-*/README.md for details

@iromli iromli requested a review from moabu as a code owner June 16, 2022 22:36
@iromli iromli linked an issue Jun 16, 2022 that may be closed by this pull request
Add support for jmx exporter #682
Closed
@iromli iromli changed the title feat: add support to expose prometheus metrics via jmx exporter feat: expose prometheus metrics via jmx exporter Jun 16, 2022
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-auth-server kind-feature Issue or PR is a new feature request labels Jun 16, 2022
moabu
moabu requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@moabu moabu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think it might be suitable to add this across our other services @iromli . Let me know your thoughts.
  • Add the required work for the helm charts @moabu

docker-jans-auth-server/Dockerfile Outdated Show resolved Hide resolved
@iromli
Copy link
Contributor Author

iromli commented Jun 20, 2022 •
edited by moabu
Loading

  • I think it might be suitable to add this across our other services @iromli . Let me know your thoughts.

@moabu Yes, we can add jmx_prometheus_javaagent to all jetty-based services (auth-server, config-api, scim, fido2, client-api)

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[jans-client-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iromli iromli requested a review from moabu June 20, 2022 17:58
@moabu moabu merged commit 205e320 into main Jun 21, 2022
@moabu moabu deleted the cn-prom-metrics branch June 21, 2022 05:23
@mo-auto2 mo-auto2 mentioned this pull request Jul 6, 2022
Merged
This was referenced Jul 6, 2022
Merged
Merged
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request Jul 6, 2022
Merged
@mecsys
Copy link

mecsys commented Aug 11, 2022

Very nice feature!

This was referenced Aug 30, 2022
Merged
Merged
Merged
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-auth-server comp-docker-jans-client-api comp-docker-jans-config-api comp-docker-jans-fido2 comp-docker-jans-scim kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for jmx exporter
4 participants
@iromli @mecsys @moabu @mo-auto