Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): fixes for path conflict for SCIM config and spec for UMA Resource mandatory fields #1805

Merged
merged 13 commits into from
Jul 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions jans-config-api/docs/jans-config-api-swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2693,7 +2693,7 @@ paths:
- oauth2: [https://jans.io/oauth/config/user.write]


/jans-config-api/scim/config:
/jans-config-api/scim/scim-config:
get:
summary: Retrieves SCIM App configuration.
description: Retrieves SCIM configuration.
Expand Down Expand Up @@ -5541,9 +5541,8 @@ components:
description: UMAResource
type: object
required:
- id
- type
- iconUri
- name
- description
properties:
dn:
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import jakarta.ws.rs.core.MediaType;
import jakarta.ws.rs.core.Response;

@Path(Constants.CONFIG)
@Path(Constants.SCIM_CONFIG)
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
public class ScimConfigResource {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ private Constants() {}
public static final String SCIM_CONFIGURATION_ENTRY = "scim_ConfigurationEntryDN";
public static final String BASE_API_URL = "/";
public static final String SCIM = "/scim";
public static final String CONFIG = "/config";
public static final String SCIM_CONFIG = "/scim-config";
public static final String USER = "/user";

}
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function() {
accessToken: '123',

//scim
scim_config_url: baseUrl + '/jans-config-api/scim/config',
scim_config_url: baseUrl + '/jans-config-api/scim/scim-config',
};

karate.configure('connectTimeout', 30000);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function() {


//scim
scim_config_url: baseUrl + '/jans-config-api/scim/config',
scim_config_url: baseUrl + '/jans-config-api/scim/scim-config',
};

karate.configure('connectTimeout', 30000);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@
]
},
{
"path":"/jans-config-api/scim/config",
"path":"/jans-config-api/scim/scim-config",
"conditions":[
{
"httpMethods":["GET"],
Expand Down