Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): fix for acr error handling and spec enhancement for example #2443

Merged
merged 10 commits into from
Sep 22, 2022
Merged

fix(config-api): fix for acr error handling and spec enhancement for example #2443

merged 10 commits into from
Sep 22, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Sep 22, 2022

Prepare

Description

Default authentication method fixed error handling
Swagger spec for example

Target issue

closes #2228 and 2354

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

pujavs and others added 10 commits September 16, 2022 18:09
@pujavs
fix(jans): config api and client api
542fa93
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
efd1543 
…ns-fixes
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
703410e 
…ns-fixes
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
b06aa44 
…ns-fixes
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
4469611 
…ns-fixes
@pujavs
docs(config-api): default value for Client attribute applicationType set
a3c79b9
@jgomer2001 @pujavs
docs: fix layout #2425 (#2433)
a0131c2
@yuremm @yurem @pujavs
fix: cb ttl update sdk 3 (#2434)
3a1df08 
* fix: CB SDK 3.x duration expiration max value can be 18 250 days

* chore: merge samples

Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a820511 
…ns-fixes
@pujavs
feat(config-api): swagger spec changes for example and fix for acr
59865bc
@pujavs pujavs requested a review from yuriyz as a code owner September 22, 2022 16:37
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Sep 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs pujavs mentioned this pull request Sep 22, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz merged commit 8113841 into main Sep 22, 2022
@yuriyz yuriyz deleted the jans-fixes branch September 22, 2022 19:44
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-config-api): issues in updating the default authentication method
5 participants
@pujavs @yuriyz @mo-auto @jgomer2001 @yuremm