Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-fido2):move appleWebauthnRootCa to Fido2 configurations issue#4744 #4756

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jmunozherbas
Copy link
Contributor

Prepare


Description

Moving the harcoded value, to Fido2 configurations

Target issue

#4744

closes #4744

Implementation Details

Property was implemented
docs were updated
installer was updated including default value


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Apr 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Milton-Ch Milton-Ch marked this pull request as ready for review June 6, 2023 04:36
Copy link
Contributor

@yurem yurem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding separate folder "appleWebauthnRootCa":"%(fido2ConfigFolder)s/apple/", can we use existing property folder "authenticatorCertsFolder":"%(fido2ConfigFolder)s/authenticator_cert" ?
The purpose for both are the same.

In AttestationCertificateService we have rootCertificatesMap from which we can get root cert by CN, etc..

Also we neeed to add Super Gluu to this folder as well and enable Root SG check on attestation

@Milton-Ch Milton-Ch force-pushed the fix-jans-fido2-applerootcertpath-parameter-issue-4744 branch from ab04c84 to a38fb61 Compare June 8, 2023 03:47
…/authentication_cert folder and read from AttestationCertificateService
@Milton-Ch Milton-Ch force-pushed the fix-jans-fido2-applerootcertpath-parameter-issue-4744 branch from a38fb61 to 5001511 Compare June 8, 2023 04:16
@yurem yurem merged commit 1600185 into main Jun 8, 2023
1 check passed
@yurem yurem deleted the fix-jans-fido2-applerootcertpath-parameter-issue-4744 branch June 8, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jans-fido2: create a config parameter appleRootCertPath
4 participants