Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-auth-server): compare contents before pushing otp_configuration and super_gluu_creds to secrets #4798

Merged
merged 2 commits into from
May 24, 2023
Merged

fix(docker-jans-auth-server): compare contents before pushing otp_configuration and super_gluu_creds to secrets #4798

merged 2 commits into from
May 24, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 3, 2023 •
edited

Prepare

Description

Target issue

closes #4797

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner May 3, 2023 17:51
@iromli iromli changed the title fix(docker-jans-auth-server): compare contents before pushing otp_con… fix(docker-jans-auth-server): compare contents before pushing otp_configuration and super_gluu_creds to secrets May 3, 2023
@mo-auto mo-auto added comp-docker-jans-auth-server kind-bug Issue or PR is a bug in existing functionality labels May 3, 2023
@moabu moabu merged commit 23f2630 into main May 24, 2023
2 checks passed
@moabu moabu deleted the cn-compare-contents branch May 24, 2023 17:14
@mo-auto2 mo-auto2 mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-auth-server kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@iromli @moabu @mo-auto