Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform-provider-jans): erorrs while using fido2 app configuration resource #5015

Merged
merged 2 commits into from
May 16, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 16, 2023

Prepare


Description

Target issue

closes #5013

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

…ion resource

overview:

* fix URL to jans-config-api endpoint for FIDO2 app config
* use PATCH method instead of PUT to update FIDO2 app config
@iromli iromli requested a review from moabu May 16, 2023 16:28
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label May 16, 2023
@moabu moabu merged commit 2275670 into main May 16, 2023
1 check passed
@moabu moabu deleted the tf-fido2-config branch May 16, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(terraform-provider-jans): erorrs while using fido2 app configuration resource
3 participants