Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): add missing options for auth-server-key-rotation #5044

Merged
merged 2 commits into from
May 22, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 19, 2023

Prepare


Description

Target issue

closes #5043

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-certmanager kind-feature Issue or PR is a new feature request labels May 19, 2023
@iromli
Copy link
Contributor Author

iromli commented May 19, 2023

Tested using default options:

root@iromli-lenient-ram:~/jans/charts/janssen# kubectl logs -f jans-auth-server-key-rotation-28075480-8rksd                                           
INFO - certmanager - 2023-05-19 20:40:03,535 - Processing updates for service auth                                                                    
INFO - certmanager - 2023-05-19 20:40:04,048 - Generating new /etc/certs/auth-keys.json and /etc/certs/auth-keys.jks                                  
INFO - certmanager - 2023-05-19 20:40:04,049 - Found existing SSA keys ... generating keys with key_ops_type=connect                                  
INFO - certmanager - 2023-05-19 20:40:09,358 - Merging keys from previous rotation (if any)                                                           
INFO - certmanager - 2023-05-19 20:40:31,561 - creating backup of jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.json                         
INFO - certmanager - 2023-05-19 20:40:31,644 - creating new jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.json                               
INFO - certmanager - 2023-05-19 20:40:31,812 - creating backup of jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.jks                          
INFO - certmanager - 2023-05-19 20:40:31,891 - creating new jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.jks                                
INFO - certmanager - 2023-05-19 20:40:32,054 - modifying jans-auth configuration                                                                      
INFO - certmanager - 2023-05-19 20:40:32,055 - using keySelectionStrategy NEWER             

Tested using keysStrategy=OLDER and keysPushDelay=30:

root@iromli-lenient-ram:~/jans/charts/janssen# kubectl logs -f jans-auth-server-key-rotation-28075485-4wc65
INFO - certmanager - 2023-05-19 20:45:03,378 - Processing updates for service auth
INFO - certmanager - 2023-05-19 20:45:03,927 - Generating new /etc/certs/auth-keys.json and /etc/certs/auth-keys.jks
INFO - certmanager - 2023-05-19 20:45:03,928 - Found existing SSA keys ... generating keys with key_ops_type=connect
INFO - certmanager - 2023-05-19 20:45:09,253 - Merging keys from previous rotation (if any)
INFO - certmanager - 2023-05-19 20:45:32,947 - creating backup of jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.json
INFO - certmanager - 2023-05-19 20:45:33,044 - creating new jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.json
INFO - certmanager - 2023-05-19 20:45:33,216 - modifying jans-auth configuration
INFO - certmanager - 2023-05-19 20:45:33,216 - using keySelectionStrategy OLDER
INFO - certmanager - 2023-05-19 20:45:33,744 - Waiting for private key push delay (30 seconds) ...
INFO - certmanager - 2023-05-19 20:46:03,745 - creating backup of jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.jks
INFO - certmanager - 2023-05-19 20:46:03,838 - creating new jans-auth-server-599d5fb96f-2nwgv:/etc/certs/auth-keys.jks
INFO - certmanager - 2023-05-19 20:46:04,385 - using keySelectionStrategy NEWER

@iromli iromli marked this pull request as ready for review May 19, 2023 20:50
@iromli iromli requested a review from moabu as a code owner May 19, 2023 20:50
@moabu moabu merged commit ef43fab into main May 22, 2023
2 checks passed
@moabu moabu deleted the cn-certmanager-opts branch May 22, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-certmanager kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(charts): add missing options for auth-server-key-rotation
3 participants