New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jans-link support in CN #5546
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitted some changes to the charts. I still see CacheRefresh mentioned here . Is there anything upstream requiring holding that name ? If not we should restrain to the link
name in envs and variables as well.
Closed #5300 in favor of this PR |
Yes, upstream doesnt change all the occurences to jans-link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jans link will not work due to the liveness and readiness probes set to endpoints that do not exist. Upstream changes will be implemented .
Prepare
Description
Target issue
closes #5136
Implementation Details
Test and Document the changes