Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jans-link support in CN #5546

Merged
merged 8 commits into from Jul 24, 2023
Merged

feat: add jans-link support in CN #5546

merged 8 commits into from Jul 24, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jul 13, 2023

Prepare


Description

Target issue

closes #5136

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner July 13, 2023 17:29
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-config-api comp-docker-jans-persistence-loader kind-feature Issue or PR is a new feature request labels Jul 13, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submitted some changes to the charts. I still see CacheRefresh mentioned here . Is there anything upstream requiring holding that name ? If not we should restrain to the link name in envs and variables as well.

@moabu
Copy link
Member

moabu commented Jul 17, 2023

Closed #5300 in favor of this PR

@iromli
Copy link
Contributor Author

iromli commented Jul 17, 2023

submitted some changes to the charts. I still see CacheRefresh mentioned here . Is there anything upstream requiring holding that name ? If not we should restrain to the link name in envs and variables as well.

Yes, upstream doesnt change all the occurences to jans-link

Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jans link will not work due to the liveness and readiness probes set to endpoints that do not exist. Upstream changes will be implemented .

#5608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans comp-docker-jans-config-api comp-docker-jans-persistence-loader kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add jans-link support in CN
3 participants