Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(docker-jans): extract info from Dockerfile to build local image #5638

Merged
merged 1 commit into from Jul 25, 2023
Merged

ci(docker-jans): extract info from Dockerfile to build local image #5638

merged 1 commit into from Jul 25, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jul 25, 2023

Prepare

Description

The changeset modify Makefiles to extract required values from Dockerfile.

Target issue

closes #5637

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner July 25, 2023 16:09
@moabu moabu merged commit e60a8e5 into main Jul 25, 2023
2 checks passed
@moabu moabu deleted the cn-makefiles branch July 25, 2023 20:15
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@iromli @devrimyatar
ci(docker-jans): extract info from Dockerfile to build local image (#…
2728fc6 
…5638)

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure comp-docker-jans-auth-server comp-docker-jans-certmanager comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-persistence-loader comp-docker-jans-scim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci(docker-jans): extract info from Dockerfile to build local image
3 participants
@iromli @moabu @mo-auto