Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.md #6552

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update setup.md #6552

merged 1 commit into from
Nov 28, 2023

Conversation

corriganjeff
Copy link
Contributor

Removed gluu reference. Need gluu's input though on the casa and other references.

@corriganjeff
Update setup.md
ede514e 
Removed gluu reference. Need gluu's input though on the casa and other references.
@ossdhaval
Copy link
Contributor

@corriganjeff Thank you for creating this PR.

You can change Gluu/Flex Casa to Jans Casa.

@ossdhaval ossdhaval self-requested a review November 22, 2023 02:24
@ossdhaval ossdhaval added kind-bug Issue or PR is a bug in existing functionality area-documentation Documentation needs to change as part of issue or PR priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system labels Nov 22, 2023
@ossdhaval
Copy link
Contributor

ossdhaval commented Nov 22, 2023 •
edited
Loading

Also, if you can add DCO to your commits, and follow the conventional commits guidlines for commit messages. Refer to Contribution Guidelines.

@moabu moabu merged commit 9d379ec into JanssenProject:main Nov 28, 2023
1 of 2 checks passed
@moabu
Copy link
Member

moabu commented Nov 28, 2023

@corriganjeff I fixed the commit and DCO . Please follow the standards as listed by my colleague

#6552 (comment)

devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@corriganjeff @devrimyatar
docs: fix setup.md (#6552)
e4a612b 
Removed gluu reference. Need gluu's input though on the casa and other references.

Signed-off-by: Author Name <36687287+corriganjeff@users.noreply.github.com >
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@ossdhaval ossdhaval Awaiting requested review from ossdhaval

Assignees

@corriganjeff corriganjeff

Labels
area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corriganjeff @ossdhaval @moabu