Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add postgres option #6557

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: add postgres option #6557

merged 2 commits into from
Nov 16, 2023

Conversation

misba7
Copy link
Contributor

@misba7 misba7 commented Nov 13, 2023 •
edited by mo-auto
Loading

Prepare

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #6558,

@misba7
feat: add postgres option
50dfe3c 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7 misba7 requested a review from iromli November 13, 2023 21:25
@misba7 misba7 requested a review from moabu as a code owner November 13, 2023 21:25
@mo-auto mo-auto mentioned this pull request Nov 13, 2023
Closed
@mo-auto
Copy link
Member

mo-auto commented Nov 13, 2023

Error: Hi @misba7, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure kind-feature Issue or PR is a new feature request labels Nov 13, 2023
@iromli
Copy link
Contributor

iromli commented Nov 14, 2023

@misba7 got this error while trying to install

Error: INSTALLATION FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
janssen:
- config.configmap.cnSqlDbDialect: Does not match pattern '^(mysql)$'

@misba7
feat: allow postgres option
696945a 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@iromli iromli self-requested a review November 15, 2023 15:46
@moabu moabu merged commit ed47585 into main Nov 16, 2023
2 checks passed
@moabu moabu deleted the jans-script-pg branch November 16, 2023 07:16
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@misba7 @devrimyatar
feat: add postgres option (#6557)
1bf9630 
* feat: add postgres option

Signed-off-by: Amro Misbah <amromisba7@gmail.com>

* feat: allow postgres option

Signed-off-by: Amro Misbah <amromisba7@gmail.com>

---------

Signed-off-by: Amro Misbah <amromisba7@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iromli iromli iromli approved these changes

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: feat: add postgres option -autocreated
4 participants
@misba7 @mo-auto @iromli @moabu