Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config-api): auth featureFlags should be described as enum in spec #6590

Merged
merged 10 commits into from Nov 20, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Nov 20, 2023

Prepare


Description

featureFlags is defined as list of string indicating the selected featureFlags. However need to display all available featureFlags as enum to client

Target issue

closes #6589

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…ientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…tion

Signed-off-by: pujavs <pujas.works@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR labels Nov 20, 2023
@yuriyz yuriyz merged commit fdf33c1 into main Nov 20, 2023
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-config-api_issue branch November 20, 2023 11:00
Copy link

sonarcloud bot commented Nov 20, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
…ec (#6590)

* fix(config-api): source LDAP server test

* feat(config-api): pom changes for org json

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): json dependency changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): json build issue and saml plugin swagger spec annotation

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(config-api): auth featureFlags should be described as enum in spec

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(config-api): auth featureFlags should be described as enum in spec
3 participants