Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing attribute name #6631

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: add missing attribute name #6631

merged 1 commit into from
Nov 28, 2023

Conversation

jgomer2001
Copy link
Contributor

@jgomer2001 jgomer2001 commented Nov 27, 2023 •
edited by mo-auto
Loading

Prepare

Description

Target issue

closes #6624

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #6632,

@mo-auto
Copy link
Member

mo-auto commented Nov 27, 2023

Error: Hi @jgomer2001, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Nov 27, 2023
Closed
@mo-auto mo-auto added comp-jans-linux-setup Component affected by issue or PR comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality labels Nov 27, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz merged commit 86bbfa9 into main Nov 28, 2023
3 of 4 checks passed
@yuriyz yuriyz deleted the agama-issues_6624 branch November 28, 2023 05:31
@mo-auto3 mo-auto3 mentioned this pull request Dec 11, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@jgomer2001 @devrimyatar
fix: add missing attribute name #6624 (#6631)
0dc5a1d 
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar devrimyatar approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-agama Touching folder /agama comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: fix: add missing attribute name -autocreated fix(agama): update tests wrt latest transpiler changes
4 participants
@jgomer2001 @mo-auto @yuriyz @devrimyatar