Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idp-plugin): inbound SAML with Keycloak as SP and external SAML IDP #6793

Merged
merged 79 commits into from Nov 29, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Nov 28, 2023

Prepare


Description

New config-api plugin for inbound SAML functionality
Three new endpoints

  1. jans-config-api/idp/idp-config: to manage Jans IDP configuration in DB
  2. jans-config-api/idp/realm: CRUD endpoints for creation and managing relam in Jans DB and KC server
  3. /jans-config-api/idp/kc/saml/: CRUD endpoints for creation and managing Identity Broker in Jans DB and KC server

Target issue

closes #6288

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs requested a review from yuriyz November 28, 2023 18:43
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Copy link

sonarcloud bot commented Nov 29, 2023

[jans-config-api-parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability B 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 146 Code Smells

0.0% 0.0% Coverage
10.6% 10.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

sonarcloud bot commented Nov 29, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz yuriyz merged commit bc5eaad into main Nov 29, 2023
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-config-6288 branch November 29, 2023 09:46
devrimyatar added a commit that referenced this pull request Dec 30, 2023
…IDP (#6793)

* feat(keycloak): module for keycloak identify provider

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): keycloak idp module wip

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): idp module wip

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): rename kc sub module

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): rename kc broker package

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): kc broker classes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): kc broker classes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(keycloak): idp endpoint wip

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): identiy provider creation

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp-plugin wip

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(Config-api): idp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin dependency changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp_plugin): dependency and model changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(jans-linux-setup): schema definition should not contain apostrophe

* feat(config-api): dependency changes for json

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): isp plugin changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp pom changes and assembly changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): idp changes for logging level and file name

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): keycloak idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): keycloak idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): keycloak idp plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin) - code cleanup

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin) - dependency changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin) - dependency version for mapstruct and profile changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin) - dependency version for mapstruct and profile changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): refctor

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): sp metadata endpoint

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): idp plugin spec and config endpoint

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): code cleanup

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): code cleanup

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): idp plugin code

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): idp relam endpoint changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): idp relam endpoint changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): resolved review comment

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): resolved review comment

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(idp-plugin): resolved review comment

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): fixed review comments wrt to logs

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(jans-linux-setup): jans-idp configuration

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Co-authored-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(keycloak): inbound SAML with Keycloak as SP and external SAML IDP
3 participants