Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kc-saml-plugin): saml enhancement for validation #6949

Merged
merged 17 commits into from
Dec 9, 2023
Merged

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 5, 2023

Prepare


Description

Target issue

closes #6869

Implementation Details

Added validation and refactored code for kc-saml-plugin

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs reopened this Dec 5, 2023
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
yuriyz
yuriyz previously approved these changes Dec 5, 2023
devrimyatar
devrimyatar previously approved these changes Dec 6, 2023
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs dismissed stale reviews from devrimyatar and yuriyz via 33d0c77 December 8, 2023 12:10
Signed-off-by: pujavs <pujas.works@gmail.com>
Copy link

sonarcloud bot commented Dec 8, 2023

[keycloak-integration-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Dec 8, 2023

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Dec 8, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Signed-off-by: pujavs <pujas.works@gmail.com>
Copy link

sonarcloud bot commented Dec 8, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.6% 0.6% Duplication

@pujavs
Copy link
Contributor Author

pujavs commented Dec 8, 2023

@yuriyz and @devrimyatar, request your approval again.
There were conflicts due to which merge did not happen. And there were later PR's for same feature which were merged in main which i had to take into account and hence the re-approval required.
Sorry for the same.

@yuriyz yuriyz enabled auto-merge (squash) December 8, 2023 16:03
@yuriyz yuriyz merged commit ba07f32 into main Dec 9, 2023
4 checks passed
@yuriyz yuriyz deleted the jans-config-6869 branch December 9, 2023 11:56
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
* feat(kc-saml-plugin): renamed plugin

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): refactor and improvement issue#6869

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): saml and idp merge

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): saml and idp merge

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): saml and idp merge

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): saml enhancement

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): saml enhancement for validation

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): removed redundant spec

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): removed redundant spec

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): added validation for mandatory element

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(kc-saml-plugin): merge conflict

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(kc-saml-plugin): fixed sonar review comments

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(config-api-kc-saml-plugin): refactor and incorporating improvement suggestions
3 participants