Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): hide authenticationMethod client model utility method #7063

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix(config-api): hide authenticationMethod client model utility method #7063

merged 2 commits into from
Dec 12, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 12, 2023

Prepare

Description

Target issue

closes #7061

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Dec 12, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz enabled auto-merge (squash) December 12, 2023 10:38
@yuriyz yuriyz merged commit 66cea41 into main Dec 12, 2023
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-config-issues branch December 12, 2023 14:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed for 'jans-cli'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

This was referenced Dec 14, 2023
Merged
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@pujavs @devrimyatar
fix(config-api): hide authenticationMethod client model utility method …
b20460c 
…#7061 (#7063)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@moabu moabu moabu approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-api): hide authenticationMethod client model utility method
4 participants
@pujavs @yuriyz @moabu @mo-auto