Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): changes for json processing of customattribute & tokenEndpointAuthMethod definition in spec #7135

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix(config-api): changes for json processing of customattribute & tokenEndpointAuthMethod definition in spec #7135

merged 2 commits into from
Dec 18, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 18, 2023

Prepare

Description

  • 7082: Json processing handling for request with displayName value as null for custom attribute.
  • 7134: tokenEndpointAuthMethod to be defined as enum in sepc

Target issue

closes #7082 , #7134

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
feat(config-api): changes for issue 7082 and 7134
7ce309d 
Signed-off-by: pujavs <pujas.works@gmail.com>
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Dec 18, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'orm'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yuriyz yuriyz enabled auto-merge (squash) December 18, 2023 14:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yuriyz yuriyz merged commit 51064e3 into main Dec 18, 2023
3 checks passed
@yuriyz yuriyz deleted the jans-config-api-issue branch December 18, 2023 14:42
@pujavs pujavs mentioned this pull request Dec 19, 2023
Closed
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@pujavs @yuriyz @devrimyatar
feat(config-api): improved tokenEndpointAuthMethod swagger definition (…
237ab95 
…#7135)

Signed-off-by: pujavs <pujas.works@gmail.com>
Co-authored-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@moabu moabu moabu approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-api): user edit error due displayName field
4 participants
@pujavs @yuriyz @moabu @mo-auto