Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-all-in-one): incorrect image tags prevent image build #7156

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix(docker-jans-all-in-one): incorrect image tags prevent image build #7156

merged 3 commits into from
Dec 19, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Dec 19, 2023 •
edited by mo-auto
Loading

Prepare

Description

Target issue

closes #7155

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #7158,

@iromli
fix(docker-jans-all-in-one): incorrect image tags prevent image build
a6b5b23 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner December 19, 2023 17:29
@iromli iromli requested a review from misba7 December 19, 2023 17:30
@moabu moabu merged commit 818ea0f into main Dec 19, 2023
2 checks passed
@moabu moabu deleted the cn-aio-versioning branch December 19, 2023 17:56
@mo-auto
Copy link
Member

mo-auto commented Dec 19, 2023

Error: Hi @iromli, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Dec 19, 2023
Closed
@mo-auto mo-auto added comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one kind-bug Issue or PR is a bug in existing functionality labels Dec 19, 2023
yurem pushed a commit that referenced this pull request Dec 21, 2023
@iromli @moabu @yurem
fix(docker-jans-all-in-one): incorrect image tags prevent image build (…
61b18eb 
…#7156)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@iromli @moabu @devrimyatar
fix(docker-jans-all-in-one): incorrect image tags prevent image build (…
e0a6511 
…#7156)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
@mo-auto2 mo-auto2 mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@misba7 misba7 Awaiting requested review from misba7

Assignees
No one assigned
Labels
comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@iromli @mo-auto @moabu