Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-fido2): none assertiona and unit test for none attestation #7199

Merged
merged 3 commits into from
Dec 25, 2023
Merged

fix(jans-fido2): none assertiona and unit test for none attestation #7199

merged 3 commits into from
Dec 25, 2023

Conversation

Milton-Ch
Copy link
Contributor

@Milton-Ch Milton-Ch commented Dec 24, 2023 •
edited
Loading

Prepare

Description

  • added none assertion with unit test
  • added unit test for none attestation
  • add residentKey in attestation

closes #7122

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality labels Dec 24, 2023
@Milton-Ch
feat(jans-fido2): added residentKey in attestation
586b116 
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
@Milton-Ch
feat(jans-fido2): none assertion test and unit test for none attestation
d87de73 
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
@Milton-Ch Milton-Ch marked this pull request as ready for review December 24, 2023 19:03
@Milton-Ch Milton-Ch changed the title fix: none assertion fix(jans-fido2): none assertiona and unit test for none attestation Dec 24, 2023
@yurem yurem enabled auto-merge (squash) December 25, 2023 14:03
@yurem yurem merged commit a134ac9 into main Dec 25, 2023
1 check passed
@yurem yurem deleted the fix/none-assertion branch December 25, 2023 14:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'jans-cli'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'agama parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'jans-core'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Failed Quality Gate failed for 'Fido2 API'

Failed conditions

11 New Code Smells (required ≤ 8)
44 Duplicated Lines on New Code (required ≤ 20)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'orm'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'SCIM API'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@Milton-Ch @devrimyatar
fix(jans-fido2): none assertiona and unit test for none attestation (#…
131f193 
…7199)

* feat(jans-fido2): added residentKey in attestation

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>

* feat(jans-fido2): none assertion test and unit test for none attestation

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>

---------

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
yurem pushed a commit that referenced this pull request Jan 1, 2024
@Milton-Ch @yurem
fix(jans-fido2): none assertiona and unit test for none attestation (#…
138452f 
…7199)

* feat(jans-fido2): added residentKey in attestation

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>

* feat(jans-fido2): none assertion test and unit test for none attestation

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>

---------

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@moabu moabu moabu approved these changes

@maduvena maduvena Awaiting requested review from maduvena

Assignees
No one assigned
Labels
comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-fido2): none assertion not working
4 participants
@Milton-Ch @yurem @moabu @mo-auto