Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-pycloudlib): rename CN_LOCK env vars to avoid conflict with jans-lock #7265

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jan 4, 2024

Prepare


Description

Target issue

closes #6636
closes #7264

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
…with jans-lock

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from misba7 January 4, 2024 17:44
@iromli iromli requested a review from moabu as a code owner January 4, 2024 17:44
@mo-auto mo-auto added comp-jans-pycloudlib kind-enhancement Issue or PR is an enhancement to an existing functionality labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@43af37a). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7265   +/-   ##
=======================================
  Coverage        ?   60.69%           
=======================================
  Files           ?       36           
  Lines           ?     3086           
  Branches        ?        0           
=======================================
  Hits            ?     1873           
  Misses          ?     1213           
  Partials        ?        0           
Flag Coverage Δ
unittests 60.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@moabu moabu merged commit 8b5a9ab into main Jan 4, 2024
6 checks passed
@moabu moabu deleted the cn-oci-lock branch January 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
3 participants