Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-saml): unable to access KC admin console from browser #7336

Merged
merged 3 commits into from Jan 11, 2024
Merged

fix(docker-jans-saml): unable to access KC admin console from browser #7336

merged 3 commits into from Jan 11, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jan 11, 2024 •
edited

Prepare

Description

Target issue

closes #7330

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
fix(docker-jans-saml): unable to access KC admin console from browser
62eea9c 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner January 11, 2024 08:46
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 11, 2024
moabu
moabu requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the credentials for KC were not provided I think it would be better for the it to be generated and pushed into the secret layer rendering providing the credential file an override option rather than the first and default option.

@iromli
chore(docker-jans-saml): generate defaults KC credentials
7611604 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu January 11, 2024 18:21
@moabu moabu merged commit ba2c0a3 into main Jan 11, 2024
2 checks passed
@moabu moabu deleted the cn-saml-admin-console branch January 11, 2024 18:28
@mo-auto2 mo-auto2 mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans-saml): unable to access KC admin console from browser
3 participants
@iromli @moabu @mo-auto