Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rework sample-cred-plugin #7339

Merged
merged 3 commits into from Jan 11, 2024
Merged

chore: rework sample-cred-plugin #7339

merged 3 commits into from Jan 11, 2024

Conversation

jgomer2001
Copy link
Contributor

Prepare

Description

Target issue

closes #7289

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@jgomer2001
docs: update TOC #7289
43c0eb8 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001
chore: remove previous sample cred plugin #7289
7e466e5 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001
chore: rewrite sample cred plugin and add docs #7289
fb0b8c1 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-dependencies Pull requests that update a dependency file labels Jan 11, 2024
@moabu moabu merged commit 0152c24 into main Jan 11, 2024
2 checks passed
@moabu moabu deleted the docs-issue_7289 branch January 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@maduvena maduvena Awaiting requested review from maduvena maduvena is a code owner

@ossdhaval ossdhaval Awaiting requested review from ossdhaval

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(jans-casa): rework sample-cred-plugin
3 participants
@jgomer2001 @moabu @mo-auto