Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker-jans-scim): use Java JDK instead of JRE to avoid compiler error #7375

Merged
merged 2 commits into from
Jan 22, 2024
Merged

chore(docker-jans-scim): use Java JDK instead of JRE to avoid compiler error #7375

merged 2 commits into from
Jan 22, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jan 15, 2024

Prepare

Description

Target issue

closes #7374

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
chore(docker-jans-scim): use Java JDK instead of JRE to avoid compile…
ddb6c54 
…r error

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner January 15, 2024 18:55
@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure comp-docker-jans-scim kind-dependencies Pull requests that update a dependency file labels Jan 15, 2024
@iromli iromli marked this pull request as draft January 15, 2024 19:42
@moabu
Copy link
Member

moabu commented Jan 15, 2024

Let's build this on the branch and test the image output with 1.0.21

@moabu moabu marked this pull request as ready for review January 22, 2024 07:43
@moabu moabu merged commit b88bab6 into main Jan 22, 2024
3 checks passed
@moabu moabu deleted the cn-scim-jdk branch January 22, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure comp-docker-jans-scim kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans-scim): use Java JDK instead of JRE to avoid compiler error
3 participants
@iromli @moabu @mo-auto