Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-fido2): generation assertion options without username #7573

Merged
merged 3 commits into from
Feb 5, 2024
Merged

feat(jans-fido2): generation assertion options without username #7573

merged 3 commits into from
Feb 5, 2024

Conversation

Milton-Ch
Copy link
Contributor

@Milton-Ch Milton-Ch commented Jan 29, 2024 •
edited
Loading

Prepare

Description

  • New endpoint /assertion/options/generate.
  • This endpoint is used to generate an assertion without passing a user, then it can authenticate any of the fmt types (packet, tpm, android-key, apple, etc.).

passkey1

closes #7356

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@Milton-Ch Milton-Ch requested a review from yurem as a code owner January 29, 2024 02:50
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jan 29, 2024
@Milton-Ch Milton-Ch mentioned this pull request Jan 29, 2024
Closed
yurem
yurem reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@yurem yurem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add 2 changes:

  1. Option to disable these endpoints
  2. Add new endpoints to ./well-known/fido2-configuration

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Milton-Ch Milton-Ch force-pushed the feat/fido-assertion-generate branch 3 times, most recently from c3fe0f3 to 318297d Compare February 2, 2024 01:11
@Milton-Ch
feat(jans-fido2): generation assertion options without username
f730b6f 
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-linux-setup Component affected by issue or PR labels Feb 2, 2024
@Milton-Ch
Copy link
Contributor Author

We need to add 2 changes:

  1. Option to disable these endpoints
  2. Add new endpoints to ./well-known/fido2-configuration

@yurem I have completed the suggested changes

@nynymike
Copy link
Contributor

nynymike commented Feb 2, 2024

Great work @Milton-Ch . Hopefully @yurem will clear some time soon to make a formal code review.

@yurem yurem enabled auto-merge (squash) February 2, 2024 20:52
@yurem yurem merged commit 794416c into main Feb 5, 2024
1 of 2 checks passed
@yurem yurem deleted the feat/fido-assertion-generate branch February 5, 2024 11:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed for 'Fido2 API'

Failed conditions

14 New Code Smells (required ≤ 8)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem yurem approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-casa): support, so that /assertion/options, generates without passing user
5 participants
@Milton-Ch @nynymike @yuriyz @yurem @mo-auto