Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert prompt-toolkit upgrade #7635

Merged
merged 2 commits into from
Feb 3, 2024
Merged

fix: revert prompt-toolkit upgrade #7635

merged 2 commits into from
Feb 3, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #7634

@devrimyatar devrimyatar marked this pull request as draft February 3, 2024 08:23
@devrimyatar
Revert "feat(jans-cli-tui): update to prompt_toolkit v3 (#7491)"
1b094bf 
This reverts commit dcc3abd.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar
Revert "fix(jans-linux-setup): update prompt-toolkit 3.0.43 (#7604)"
af7758e 
This reverts commit e35963f.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@mo-auto mo-auto added comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
10.5% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@devrimyatar devrimyatar marked this pull request as ready for review February 3, 2024 08:33
@moabu moabu merged commit b3f6834 into main Feb 3, 2024
2 checks passed
@moabu moabu deleted the jans-linux-setup-7634 branch February 3, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: revert promptoolkit upgrade
3 participants
@devrimyatar @moabu @mo-auto