Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-certmanager): resolve key_ops_type created on key rotation #7712

Merged
merged 7 commits into from
Feb 14, 2024
Merged

fix(docker-jans-certmanager): resolve key_ops_type created on key rotation #7712

merged 7 commits into from
Feb 14, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Feb 13, 2024

Prepare

Description

Target issue

closes #7711

Implementation Details

  • Ensure checking lowercased key_ops_type
  • Ensure checking uppercased JWK algorithm
  • Delete and/or recreate corrupted JWKS

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
fix: handle incorrect types of JWKS
670aa54 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: handle missing alg from jwks
dbb2601 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: handle corrupted web keys
6407ebf 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: collect key_ops_type with lowercase value
a08145e 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: check uppercased algorithm name in JWKS
4080139 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner February 13, 2024 16:52
@mo-auto mo-auto added comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality labels Feb 13, 2024
@moabu moabu merged commit 3c5af5b into main Feb 14, 2024
2 checks passed
@moabu moabu deleted the cn-key-rotation branch February 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
backport/v1.0.21 backport/v1.0.22 comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans-certmanager): incorrect key_ops_type created on key rotation
3 participants
@iromli @moabu @mo-auto