Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jans-cli): update cli readme #7730

Merged
merged 4 commits into from
Feb 14, 2024
Merged

docs(jans-cli): update cli readme #7730

merged 4 commits into from
Feb 14, 2024

Conversation

ossdhaval
Copy link
Contributor

Prepare

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@ossdhaval
docs(config-cli): add install and config sections
05465f2 
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval
docs(config-cli): update tasks and op-id sections
6b64637 
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval
docs(config-cli): update CLI README with diagram and content
6dc781c 
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval ossdhaval self-assigned this Feb 14, 2024
@mo-auto mo-auto added the area-documentation Documentation needs to change as part of issue or PR label Feb 14, 2024
@mo-auto mo-auto enabled auto-merge (squash) February 14, 2024 18:20
@nynymike nynymike self-requested a review February 14, 2024 19:46
nynymike
nynymike approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nynymike nynymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@mo-auto mo-auto merged commit 27e8ec1 into main Feb 14, 2024
1 of 2 checks passed
@mo-auto mo-auto deleted the docs-update-cli-readme branch February 14, 2024 20:03
devrimyatar
devrimyatar reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@devrimyatar devrimyatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devrimyatar devrimyatar devrimyatar left review comments

@nynymike nynymike nynymike approved these changes

@mo-auto mo-auto mo-auto approved these changes

Assignees

@ossdhaval ossdhaval

Labels
area-documentation Documentation needs to change as part of issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ossdhaval @nynymike @devrimyatar @mo-auto @moabu