feat(jans-pycloudlib): allow configurable Vault KV and AppRole paths #7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
mo-auto
added
comp-jans-pycloudlib
kind-feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7775 +/- ##
=======================================
Coverage ? 60.94%
=======================================
Files ? 36
Lines ? 3124
Branches ? 0
=======================================
Hits ? 1904
Misses ? 1220
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: iromli <isman.firmansyah@gmail.com>
|
moabu
approved these changes
Feb 19, 2024
yurem
pushed a commit
that referenced
this pull request
Feb 20, 2024
…7775) * refactor(jans-pycloudlib): handle Vault KV version 1 Signed-off-by: iromli <isman.firmansyah@gmail.com> * refactor(jans-pycloudlib): handle Vault KV version 2 Signed-off-by: iromli <isman.firmansyah@gmail.com> * refactor: specify backward-compat env vars for Vault address Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: refactor vault binding Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
devrimyatar
pushed a commit
that referenced
this pull request
Feb 27, 2024
…7775) * refactor(jans-pycloudlib): handle Vault KV version 1 Signed-off-by: iromli <isman.firmansyah@gmail.com> * refactor(jans-pycloudlib): handle Vault KV version 2 Signed-off-by: iromli <isman.firmansyah@gmail.com> * refactor: specify backward-compat env vars for Vault address Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: refactor vault binding Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #7774
Implementation Details
Test and Document the changes