Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): changes to add content in script block instead of overwriting #7839

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix(docs): changes to add content in script block instead of overwriting #7839

merged 1 commit into from
Feb 23, 2024

Conversation

ossdhaval
Copy link
Contributor

Adding super() will first add the content in the script block as usual plus add the content img. More details here

Breakage was introduced by #7765

Prepare

Description

Target issue

closes #7838

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@ossdhaval
fix(docs): changes to add content in script block instead of removing
d31b1f1 
Adding `super()` will first add the content in the script block as usual plus add the content `img`

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval ossdhaval added this to the 1.1.0 milestone Feb 23, 2024
@ossdhaval ossdhaval requested a review from moabu February 23, 2024 18:49
@ossdhaval ossdhaval self-assigned this Feb 23, 2024
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 23, 2024
@mo-auto mo-auto enabled auto-merge (squash) February 23, 2024 18:56
@mo-auto mo-auto merged commit 6c1582d into main Feb 23, 2024
2 checks passed
@mo-auto mo-auto deleted the fix-docs-search branch February 23, 2024 21:07
devrimyatar pushed a commit that referenced this pull request Feb 27, 2024
@ossdhaval @devrimyatar
fix(docs): changes to add content in script block instead of removing (…
7e8ef4a 
…#7839)

Adding `super()` will first add the content in the script block as usual plus add the content `img`

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@mo-auto mo-auto mo-auto approved these changes

Assignees

@ossdhaval ossdhaval

Labels
area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

fix(docs): search and version selector not showing up on header in docs.jans.io
3 participants
@ossdhaval @moabu @mo-auto