Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade css libraries in jans-auth-server #7835 #7856

Merged
merged 11 commits into from
Apr 17, 2024
Merged

chore: upgrade css libraries in jans-auth-server #7835 #7856

merged 11 commits into from
Apr 17, 2024

Conversation

jv18creator
Copy link
Contributor

Prepare

Description

Target issue

closes #7835

Implementation Details

Libraries replaced

  • fontawesome v5.8.2 => v6.5.1
  • bootstrap v4.0.0 => v5.3.3

Libraries removed

  • jquery-ui v1.12.1

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@jv18creator
chore!(css): removed jquery ui #7835
689ebc9 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator
chore(css): upgrade Bootstrap from v4 to v5.3.3 #7835
65843c8 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator
fix(jans-auth-server): bootstrap breaking css #7835
ae541f0 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator
chore(css): upgrade fontawesome to v6.5.1 #7835
a546d3a 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator jv18creator added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Feb 27, 2024
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Feb 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'Jans lock server parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ossdhaval
Copy link
Contributor

Hi @jv18creator

I have tested these changes on authorization page and selectAccount page. Seems to be working.

As discussed you have also tested them on authentication page for user-id / password.

I think this is good to go. I'll approve.

@ossdhaval
Copy link
Contributor

Plus, You'll have to make the same changes for Casa pages as well. I think they are not using these libraries from the same location.

@jv18creator
Copy link
Contributor Author

Plus, You'll have to make the same changes for Casa pages as well. I think they are not using these libraries from the same location.

Okay @ossdhaval I will check casa codebase and try to do the same.

jv18creator and others added 3 commits April 12, 2024 12:44
@jv18creator
Merge branch 'main' into chore-upgrade-jans-css-libs
df23992
@jv18creator
chore(jans-casa): upgrade Bootstrap from v4 to v5 #7835
50c81f6 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator
chore(docs): update casa UI path
6c2ba04 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@ossdhaval
Copy link
Contributor

@jv18creator I am in favor of merging this PR now unless you are planning to add more commits.

@jv18creator jv18creator marked this pull request as ready for review April 15, 2024 08:43
@jv18creator
Copy link
Contributor Author

@jv18creator I am in favor of merging this PR now unless you are planning to add more commits.

yes please continue

@yuriyz yuriyz enabled auto-merge (squash) April 15, 2024 10:42
@jgomer2001
Copy link
Contributor

was this tested?

@ossdhaval
Copy link
Contributor

was this tested?

Hi @jgomer2001 We tested the pages below with these changes:

  • Device auth
  • password login
  • authorization page

Casa remains to be tested. We planned to test Casa using the nightly build after the PR is merged.

@yuriyz yuriyz merged commit 8dfc3f4 into main Apr 17, 2024
1 of 2 checks passed
@yuriyz yuriyz deleted the chore-upgrade-jans-css-libs branch April 17, 2024 19:12
@jgomer2001
Copy link
Contributor

Merged now @ossdhaval @jv18creator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'agama parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'orm'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'Jans lock server parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgomer2001 jgomer2001 mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@jgomer2001 jgomer2001 jgomer2001 approved these changes

@maduvena maduvena Awaiting requested review from maduvena maduvena is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

@yuriyzz yuriyzz Awaiting requested review from yuriyzz yuriyzz is a code owner

Assignees

@ossdhaval ossdhaval

@jv18creator jv18creator

Labels
comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: upgrade javascript libraries to newer versions in HTML files
5 participants
@jv18creator @ossdhaval @jgomer2001 @yuriyz @mo-auto