Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(jans-pycloudlib): destroy old secret version instead of disable #8097

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 20, 2024

Prepare


Description

Target issue

closes #7944

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@mo-auto mo-auto added comp-jans-pycloudlib kind-enhancement Issue or PR is an enhancement to an existing functionality labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@60310a0). Click here to learn what that means.

❗ Current head 585334d differs from pull request most recent head 07d20ce. Consider uploading reports for the commit 07d20ce to get more accurate results

Files Patch % Lines
...pycloudlib/jans/pycloudlib/config/google_config.py 40.00% 6 Missing ⚠️
...pycloudlib/jans/pycloudlib/secret/google_secret.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8097   +/-   ##
=======================================
  Coverage        ?   60.32%           
=======================================
  Files           ?       36           
  Lines           ?     3183           
  Branches        ?        0           
=======================================
  Hits            ?     1920           
  Misses          ?     1263           
  Partials        ?        0           
Flag Coverage Δ
unittests 60.32% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 20, 2024

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli marked this pull request as ready for review March 20, 2024 20:28
@iromli iromli requested a review from moabu as a code owner March 20, 2024 20:28
@mo-auto mo-auto added the area-documentation Documentation needs to change as part of issue or PR label Mar 20, 2024
@moabu moabu merged commit 9ec7177 into main Mar 21, 2024
3 checks passed
@moabu moabu deleted the cn-gsm-versioning branch March 21, 2024 09:27
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-pycloudlib kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf(jans-pycloudlib): handeling secret versioning
3 participants